ref(flags): don't show feature flag section on any issues besides errors #82119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
aliu39
reviewed
Dec 14, 2024
| return <FeatureFlagInlineCTA projectId={event.projectID} />; | ||
| } | ||
|
|
||
| // if contexts.flags is not set, hide the section | ||
| if (!hasFlagContext) { | ||
| if (!hasFlagContext || group.issueCategory === 'cron') { |
There was a problem hiding this comment.
Do we want to hide the whole section for crons or just the cta?
There was a problem hiding this comment.
whole section i think?
| @@ -197,12 +197,12 @@ export function EventFeatureFlagList({ | |||
| } | |||
| }, [hasFlags, hydratedFlags.length, organization]); | |||
|
|
|||
| if (showCTA) { | |||
| if (showCTA && group.issueCategory !== 'cron') { | |||
There was a problem hiding this comment.
Nit: could be part of showCTA definition in case that variables reused
aliu39
approved these changes
Dec 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82119 +/- ##
==========================================
- Coverage 80.28% 71.39% -8.89%
==========================================
Files 7506 7210 -296
Lines 331637 320907 -10730
Branches 20966 20964 -2
==========================================
- Hits 266252 229123 -37129
- Misses 64977 91376 +26399
Partials 408 408 |
cmanallen
approved these changes
Dec 16, 2024
|
@michellewzhang More specifically let's make sure we only target error issue types. |
michellewzhang
changed the title
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
…ors (#82119) the CTA was showing up for a [crons issue](https://sentry.sentry.io/issues/6139435070/events/11af5c3a9188460ab5f2edd5b583a988/?project=1) but we should probably hide it for that category.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the CTA was showing up for a crons issue but we should probably hide it for that category.