chore(utils): allow duplicate values in registry by making reverse lookup optional #82114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathteng
changed the title
github-actions
bot
added
the
Scope: Backend
saponifi3d
approved these changes
Dec 14, 2024
Co-authored-by: Josh Callender <[email protected]>
wedamija
approved these changes
Dec 14, 2024
| @@ -15,9 +15,10 @@ class NoRegistrationExistsError(ValueError): | |||
|
|
|||
|
|
|||
| class Registry(Generic[T]): | |||
| def __init__(self): | |||
| def __init__(self, enable_reverse_lookup=True): | |||
There was a problem hiding this comment.
Might be worth a docstring explaining that it's useful to disable reverse lookup when you have duplicate values
| self.registrations: dict[str, T] = {} | ||
| self.reverse_lookup: dict[T, str] = {} | ||
| self.enable_reverse_lookup = enable_reverse_lookup | ||
|
|
||
| def register(self, key: str): |
There was a problem hiding this comment.
Separately, it could also be worth changing the way we register so that we support both a decorator and a function. Not a huge priority though.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #82114 +/- ##
==========================================
- Coverage 80.37% 80.36% -0.01%
==========================================
Files 7277 7277
Lines 321488 321491 +3
Branches 20966 20966
==========================================
- Hits 258391 258382 -9
- Misses 62689 62701 +12
Partials 408 408 |
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make reverse lookup optional in
Registry. Reverse lookup via a dictionary means keys AND values must be unique (because we also have regular lookup via a dictionary), but sometimes different keys have the same value and we want to allow registration if that's the case.