ref(aci): pass WorkflowJob into process_workflows #82096
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
force-pushed
the
cathy/aci/process-workflow-kwargs
branch
from
80a3b78 to
94a8900
Compare
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #82096 +/- ##
==========================================
- Coverage 80.37% 80.36% -0.01%
==========================================
Files 7277 7277
Lines 321488 321487 -1
Branches 20966 20966
==========================================
- Hits 258391 258377 -14
- Misses 62689 62702 +13
Partials 408 408 |
cathteng
force-pushed
the
cathy/aci/process-workflow-kwargs
branch
from
f9840b8 to
0acfef2
Compare
cathteng
changed the title
ceorourke
reviewed
Dec 17, 2024
| @@ -14,11 +14,13 @@ | |||
|
|
|||
|
|
|||
| # TODO - cache these by evt.group_id? :thinking: | |||
| def get_detector_by_event(evt: GroupEvent) -> Detector: | |||
| issue_occurrence = evt.occurrence | |||
| def get_detector_by_event(job: PostProcessJob) -> Detector: | |||
ceorourke
reviewed
Dec 17, 2024
| def get_detector_by_event(evt: GroupEvent) -> Detector: | ||
| issue_occurrence = evt.occurrence | ||
| def get_detector_by_event(job: PostProcessJob) -> Detector: | ||
| issue_occurrence = job["event"].occurrence |
There was a problem hiding this comment.
could be nice to pull this off event = job["event"] since you do that twice
ceorourke
approved these changes
Dec 17, 2024
cathteng
changed the title
|
too many merge conflicts, replaced with #82489 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process_workflowsis currently called with aGroupEventfor issue types like metric issues to fire downstream actions.To process issue alerts, we use other elements of
PostProcessJobin post_process to evaluate conditions. As such, we should passPostProcessJobintoprocess_workflows. It contains theGroupEvent.PostProcessJobis aTypedDictwhich also has the benefit of allowing us to modify the input without having to refactor stuff that's already in place.