Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(settings): add search bar to repositories page #82063

Closed
wants to merge 3 commits into from

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Dec 12, 2024

closes #55836

SCR-20241212-noso
Screen.Recording.2024-12-12.at.3.20.22.PM.mov

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 12, 2024
@michellewzhang michellewzhang changed the title ref(settings): add search bar to repositories page) ref(settings): add search bar to repositories page Dec 12, 2024
@michellewzhang michellewzhang requested a review from a team December 12, 2024 23:22
@scttcper
Copy link
Member

feels like you would still need to loop through all the pages to find something?

@michellewzhang
Copy link
Member Author

feels like you would still need to loop through all the pages to find something?

what do you mean?

@scttcper
Copy link
Member

this search bar only filters results on your current page and you would need to keep flipping pages to find the repo. in the ticket they're saying they have multiple pages

@michellewzhang
Copy link
Member Author

this search bar only filters results on your current page and you would need to keep flipping pages to find the repo. in the ticket they're saying they have multiple pages

ohh okay i see. i guess with the pagination implementation it makes it hard to search all of it at once. i'll close this for now since it doesn't seem to achieve what the customer is asking

@michellewzhang michellewzhang deleted the mz/search-repo branch December 20, 2024 18:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
3 participants