feat(widget-builder): Make widget builder preview draggable #82038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
narsaynorath
approved these changes
Dec 12, 2024
| @@ -93,10 +93,10 @@ const _SlideOverPanel = styled(motion.div, { | |||
| }>` | |||
| position: fixed; | |||
|
|
|||
| top: ${space(2)}; | |||
| right: 0; | |||
| top: ${p => (p.slidePosition === 'left' ? '54px' : space(2))}; | |||
There was a problem hiding this comment.
Is there some kind of constant we could use in place of the 54px? Just trying to see if there's something a bit more semantic
| <DraggableWidgetContainer | ||
| ref={setNodeRef} | ||
| id={WIDGET_PREVIEW_DRAG_ID} | ||
| style={{ |
There was a problem hiding this comment.
We might be able to eek out some small perf gains by telling the browser these values will change.
https://developer.mozilla.org/en-US/docs/Learn/Performance/CSS#optimizing_element_changes_with_will-change
i.e. you can probably add willChange: 'opacity, transform'
|
closing this pr because i misunderstood the responsive design lol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The responsive design for the widget builder allows for a draggable preview on smaller screens. The preview is now draggable by the dnd-kit library. It is only draggable when the slideout is the full screen width (on small screens), otherwise it is not draggable. The preview is on top of the widget builder and can be shifted around for easy access to the fields. It looks like this yayyy:
Screen.Recording.2024-12-12.at.2.51.05.PM.mov
Closes #81804