Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic prototype to demonstrate dlqing stale messages #82029

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

lynnagara
Copy link
Member

the goal of this change is prioritise new messages during incident recovery, and reroute stale messages for later processing.

this PR is a prototype to demonstrate one possible approach using a DLQ

the goal of this change is prioritise new messages during incident recovery,
and reroute stale messages for later processing.

this PR is a prototype to demonstrate one possible approach using a DLQ
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/ingest/consumer/dlq_stale_messages.py 42.85% 8 Missing ⚠️
src/sentry/ingest/consumer/factory.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #82029      +/-   ##
==========================================
+ Coverage   80.36%   80.42%   +0.06%     
==========================================
  Files        7290     7284       -6     
  Lines      321739   321195     -544     
  Branches    21009    20932      -77     
==========================================
- Hits       258567   258328     -239     
+ Misses      62766    62465     -301     
+ Partials      406      402       -4     

@getsantry
Copy link
Contributor

getsantry bot commented Jan 8, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants