fix: require verified primary email before adding 2fa #81982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mdtro
changed the title
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81982 +/- ##
==========================================
- Coverage 80.35% 80.35% -0.01%
==========================================
Files 7274 7275 +1
Lines 321295 321337 +42
Branches 20955 20955
==========================================
+ Hits 258180 258209 +29
- Misses 62701 62714 +13
Partials 414 414 |
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
A user could add 2FA with a verified secondary email address, but not a verified primary address. This leads to some confusing edge cases with security impact. This PR adds a new decorator `primary_email_verification_required` that specifically ensures the account's primary email is verified for the particular endpoint it is wrapping. The endpoint used to enroll new 2FA interfaces has been switched over to this new decorator.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user could add 2FA with a verified secondary email address, but not a verified primary address. This leads to some confusing edge cases with security impact.
This PR adds a new decorator
primary_email_verification_requiredthat specifically ensures the account's primary email is verified for the particular endpoint it is wrapping. The endpoint used to enroll new 2FA interfaces has been switched over to this new decorator.