Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stack-trace): Allow sections to be expanded regardless of stack view setting #81981

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

leeandher
Copy link
Member

@leeandher leeandher commented Dec 11, 2024

Resolves #81173. Allows only the helper function to determine whether a section is expandable, allowing for registers to show even if the view isn't set to Full Stack Trace.

This will also prevent a weird case where you toggle the view, expand a section, toggle back and then can't close it.
https://sentry-sdks.sentry.io/issues/6075426538/events/e30a73a001b341972a3d1fa8cf49a949/?project=4506178389999616

Before:
image

After:
image

@leeandher leeandher requested a review from a team December 11, 2024 20:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 11, 2024
@leeandher leeandher merged commit af37b33 into master Dec 11, 2024
45 checks passed
@leeandher leeandher deleted the leander/display-registers-81173 branch December 11, 2024 21:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macOS minidumps from breakpad do not render thread context(registers)
2 participants