ref(similarity): Typing and remove feature flag #81977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Fully typed functions * Extract minor function * Always remove the current project from the cohort * This will prevent a project getting stuck in backfill
github-actions
bot
added
the
Scope: Backend
armenzg
commented
Dec 11, 2024
src/sentry/tasks/embeddings_grouping/backfill_seer_grouping_records_for_project.py
Outdated
Show resolved
Hide resolved
src/sentry/tasks/embeddings_grouping/backfill_seer_grouping_records_for_project.py
Outdated
Show resolved
Hide resolved
| @@ -109,13 +100,6 @@ def backfill_seer_grouping_records_for_project( | |||
| last_processed_group_id_input, | |||
| last_processed_project_index_input, | |||
| ) | |||
| except FeatureError: | |||
There was a problem hiding this comment.
We do not need it since the feature is fully enabled.
src/sentry/tasks/embeddings_grouping/backfill_seer_grouping_records_for_project.py
Outdated
Show resolved
Hide resolved
JoshFerge
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81977 +/- ##
========================================
Coverage 80.35% 80.36%
========================================
Files 7279 7275 -4
Lines 321306 321172 -134
Branches 20957 20933 -24
========================================
- Hits 258200 258110 -90
+ Misses 62692 62651 -41
+ Partials 414 411 -3 |
armenzg
changed the title
|
I have removed the fix. I got frustrated with the tests. I will try again another time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: