ref(insights): Refactor Resources page charts #81976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Dec 11, 2024
static/app/views/insights/browser/resources/components/charts/assetSizeChart.tsx
Outdated
Show resolved
Hide resolved
| filters={appliedFilters} | ||
| extraQuery={extraQuery} | ||
| /> | ||
| <ThroughputChart series={data['spm()']} isLoading={isPending} error={error} /> |
There was a problem hiding this comment.
This might be an inconsistency with the rest of insights, but I think isPending would be a better prop name for the ThroughputChart if that's what we expect to pass into it from useSpanMetricsSeries
There was a problem hiding this comment.
Noted, that's fair! I'll consider this when I start updating these charts soon (going to integrate new Dashboard widget components)
Bundle ReportChanges will increase total bundle size by 98.94kB (0.31%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
gggritso
deleted the
ref/insights/resource-landing-charts-data-loading
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes two important changes:
DurationChart,ThroughputChart, andAssetSizeChartcomponents. These are re-used on the landing page and the asset details page. This also brings this module more in-line with how other insights are structureduseSpanMetricsSeriesinstead ofuseSpansQuery. This is a better way to load data, since it returnsmetaand other good information. Again, better consistency with other Insights modules