feat(workflow_engine): Adding support for process_workflows in the IssuePlatform
#81975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81975 +/- ##
=======================================
Coverage 80.37% 80.37%
=======================================
Files 7275 7275
Lines 321394 321440 +46
Branches 20962 20962
=======================================
+ Hits 258316 258355 +39
- Misses 62667 62674 +7
Partials 411 411 |
wedamija
reviewed
Dec 11, 2024
Comment on lines
50
to
+51
| ERROR = "ErrorDetector" | ||
| METRIC_ALERT_FIRE = "metric_alert_fire" |
There was a problem hiding this comment.
What are these meant to map to? I feel like we should have a consistent format
There was a problem hiding this comment.
this maps to the grouptype's slug through the detector. Agree though, i'm thinking we should set these as types on the detector base class.
I was going to do that in a follow-up PR (we also need something similar for data_sources)
wedamija
approved these changes
Dec 12, 2024
saponifi3d
force-pushed
the
jcallender/post_process_workflow_engine
branch
from
9d3e9bf to
ee1fbf6
Compare
…ensure it's invoked through the system.
…, the other for handling issue occurrences
…g the data conditions on a mock update
saponifi3d
force-pushed
the
jcallender/post_process_workflow_engine
branch
from
6e30368 to
41c64a8
Compare
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
…IssuePlatform (#81975) ## Description - This PR will add a new post process group for our test `MetricIssue`. - Adds a `test_integration` with two core tests; - For processing the data and creating issue occurrences (workflow_engine -> IssuePlatform) - Another for taking occurrences and invoking workflows (IssuePlatform -> workflow_engine.workflows) --------- Co-authored-by: Snigdha Sharma <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MetricIssue.test_integrationwith two core tests;