Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(widget-builder): Integrate sort by limit field with widget builder state #81972

Merged
merged 9 commits into from
Dec 11, 2024

Conversation

nikkikapadia
Copy link
Member

@nikkikapadia nikkikapadia commented Dec 11, 2024

Enhancing functionality of the sort by field. The UI for limiting is already there, I've just integrated it with the newly added limit param in the widget builder state. The functionality of this limit is the same as what we have in the current widget builder (including the max limit conditions).

Closes #81510

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 11, 2024
@nikkikapadia nikkikapadia marked this pull request as ready for review December 11, 2024 19:24
@nikkikapadia nikkikapadia requested a review from a team as a code owner December 11, 2024 19:24
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, tested it locally and it looks good

@nikkikapadia nikkikapadia enabled auto-merge (squash) December 11, 2024 19:58
@nikkikapadia nikkikapadia merged commit b71c8d9 into master Dec 11, 2024
42 checks passed
@nikkikapadia nikkikapadia deleted the nikki/feat/widget-builder-integrate-limit branch December 11, 2024 20:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add limit
2 participants