Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(widget-builder): Split out tests #81949

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

narsaynorath
Copy link
Member

@narsaynorath narsaynorath commented Dec 10, 2024

Splits up some of these tests so they don't rely on the whole widget builder to test. I'm hoping that this makes them run better with my other context changes.

@narsaynorath narsaynorath requested a review from a team as a code owner December 10, 2024 22:21
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 10, 2024
@narsaynorath narsaynorath enabled auto-merge (squash) December 10, 2024 22:24
@narsaynorath narsaynorath merged commit dbb9929 into master Dec 10, 2024
44 checks passed
@narsaynorath narsaynorath deleted the nar/ref/widget-builder-split-up-tests branch December 10, 2024 22:33
Copy link

sentry-io bot commented Dec 10, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: �[2mexpect(�[22m�[31mjest.fn()�[39m�[2m).�[22mtoHaveBeenCalledWith�[2m(�[22m�[32m...expected�[39m... Object.?(datasetSelector.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants