ref(insights): Simplify SpanTimeCharts
#81931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That hasn't been used in a very long time
github-actions
bot
added
the
Scope: Frontend
DominikB2014
approved these changes
Dec 10, 2024
Comment on lines
+49
to
+57
| if (extraQuery) { | ||
| eventView.query += ` ${extraQuery.join(' ')}`; | ||
| } | ||
|
|
||
| const {isPending} = useSpansQuery({ | ||
| eventView, | ||
| initialData: [], | ||
| referrer: 'api.starfish.span-time-charts', | ||
| }); |
There was a problem hiding this comment.
Ideally we use useSpanMetrics here, or I suppose longterm it will be a dashboard diget?
We're not doing this because of the following comment you made right?
There's still old data loading, and other issues, but one thing at a time.
| const {isPending} = useSpansQuery({ | ||
| eventView, | ||
| initialData: [], | ||
| referrer: 'api.starfish.span-time-charts', |
There was a problem hiding this comment.
Suggested change
| referrer: 'api.starfish.span-time-charts', | |
| referrer: 'api.performance.resources.span-time-charts', |
^ Also applies to other referrers in this file
Additionally, I think ideally this comes from a referrers.ts file as the other modules do.
There was a problem hiding this comment.
I can update that in a follow-up! 👍🏻
gggritso
added a commit
that referenced
this pull request
Dec 11, 2024
We did not finish this project. The UI code is removed in #81931
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpanTimeChartsis a very old component with a lot of issues, since it uses all kinds of old hooks for fetching, and have a lot of dead code.Importantly, it's only used in one place! The Resources landing page. This PR renames it, moves it, and removes any code that isn't needed for that page.
There's still old data loading, and other issues, but one thing at a time.