feat(explore) Making samples and aggregate tables resizable #81899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81899 +/- ##
==========================================
+ Coverage 80.25% 80.34% +0.09%
==========================================
Files 7488 7259 -229
Lines 330931 320769 -10162
Branches 20876 20872 -4
==========================================
- Hits 265585 257729 -7856
+ Misses 64951 62645 -2306
Partials 395 395 |
Bundle ReportChanges will increase total bundle size by 78.55kB (0.25%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Zylphrex
reviewed
Dec 12, 2024
| gridTemplateColumns: columns.join(' '), | ||
| }; | ||
| }, [items, minimumColumnWidth]); | ||
| function onMouseUp() { |
There was a problem hiding this comment.
There's a subtle bug here where another element may have e.stopPropagation() on its onMouseUp handler and the listeners never get removed. But this should be mostly okay as it will be removed on the next mouse up anywhere.
There was a problem hiding this comment.
Yup, we can iterate on feedback, good catch though i didn't come across it
Zylphrex
approved these changes
Dec 12, 2024
evanh
pushed a commit
that referenced
this pull request
Dec 17, 2024
https://github.com/user-attachments/assets/964924fb-0f14-46b9-9e8c-b669a27f1f44 --------- Co-authored-by: Abdullah Khan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-12-10.at.11.33.28.AM.mov