Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update clickhouse version 24.3.5.47 [DO NOT MERGE...YET] #81376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MeredithAnya
Copy link
Member

We added clickhouse version 24.3.5.47 to snuba CI in getsentry/snuba#6246.

This PR is to test for any bugs in Sentry CI related to this new version. We will start upgrading production clusters in the near future, but this PR should not be merged until that work is done.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #81376      +/-   ##
==========================================
+ Coverage   78.48%   80.47%   +1.98%     
==========================================
  Files        7215     7244      +29     
  Lines      319793   320235     +442     
  Branches    44034    20727   -23307     
==========================================
+ Hits       250996   257697    +6701     
+ Misses      62404    62145     -259     
+ Partials     6393      393    -6000     

@patsevanton
Copy link
Contributor

I see many logs with:
%3|1732732470.340|FAIL|rdkafka#producer-1| [thrd:127.0.0.1:9092/bootstrap]: 127.0.0.1:9092/bootstrap: Connect to ipv4#127.0.0.1:9092 failed: Connection refused (after 0ms in state CONNECT, 30 identical error(s) suppressed)
Check if kafka is running

<profiles>
<!-- Default settings. -->
<default>
<allow_experimental_analyzer>0</allow_experimental_analyzer>
Copy link
Member Author

@MeredithAnya MeredithAnya Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like a lot of the failing tests could be because this setting is enabled by default in the newer versions. I think maybe we could be overwriting these settings in users.d directory but wasn't sure if that was for different profiles and I wanted to set this as the default

@getsantry
Copy link
Contributor

getsantry bot commented Jan 9, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Jan 9, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Feb 1, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Feb 1, 2025
@patsevanton
Copy link
Contributor

My sentry work with clickhouse 24.3

@getsantry getsantry bot removed the Stale label Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants