chore(similarity): Do not send > 30 system frames to seer #81259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
armenzg
approved these changes
Nov 25, 2024
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #81259 +/- ##
==========================================
- Coverage 80.35% 80.34% -0.01%
==========================================
Files 7221 7220 -1
Lines 319640 319595 -45
Branches 20782 20782
==========================================
- Hits 256832 256791 -41
+ Misses 62414 62410 -4
Partials 394 394 |
|
PR reverted: 104352c |
getsentry-bot
added a commit
that referenced
this pull request
Nov 25, 2024
…1259)" This reverts commit 2e3a412. Co-authored-by: jangjodi <[email protected]>
armenzg
reviewed
Nov 26, 2024
| stacktrace_string = get_stacktrace_string(get_grouping_info_from_variants(variants)) | ||
| stacktrace_string = get_stacktrace_string_with_metrics( | ||
| get_grouping_info_from_variants(variants), event.platform, ReferrerOptions.INGEST | ||
| ) | ||
| if stacktrace_string == "": |
There was a problem hiding this comment.
Maybe over here we need to check if it's None as well.
|
|
||
| if stacktrace_string == "" or not latest_event: | ||
| if not stacktrace_string or not latest_event: |
There was a problem hiding this comment.
Just because I always forget how Python behaves I test the following:
>>> def foo(b):
... if not b:
... print("hey")
...
>>> foo("")
hey
>>> foo(None)
hey
>>> foo("bar")
>>>
| @@ -217,7 +220,10 @@ def get_seer_similar_issues( | |||
| "hash": event_hash, | |||
| "project_id": event.project.id, | |||
| "stacktrace": event.data.get( | |||
| "stacktrace_string", get_stacktrace_string(get_grouping_info_from_variants(variants)) | |||
There was a problem hiding this comment.
In this function, we must always prevent request_data["stacktrace"] to be None.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
Do not send stacktraces with > 30 system frames and no in-app frames to seer
andrewshie-sentry
pushed a commit
that referenced
this pull request
Dec 2, 2024
…1259)" This reverts commit 2e3a412. Co-authored-by: jangjodi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not send stacktraces with > 30 system frames and no in-app frames to seer