chore(alerts): Remove fe code for activated alerts #81218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ceorourke
force-pushed
the
ceorourke/rm-fe-activated-alerts
branch
from
8eb56c6 to
6fa4b80
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81218 +/- ##
==========================================
+ Coverage 80.25% 80.34% +0.08%
==========================================
Files 7447 7218 -229
Lines 329627 319477 -10150
Branches 20779 20765 -14
==========================================
- Hits 264540 256681 -7859
+ Misses 64693 62402 -2291
Partials 394 394 |
saponifi3d
approved these changes
Nov 25, 2024
This was referenced Nov 25, 2024
saponifi3d
approved these changes
Dec 4, 2024
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
ceorourke
added a commit
that referenced
this pull request
Jan 6, 2025
Another chunk of https://github.com/getsentry/sentry/pull/81095/files that removes activated alerts from serializers. This can't be merged until #81218 is merged.
ceorourke
added a commit
that referenced
this pull request
Jan 6, 2025
ceorourke
added a commit
that referenced
this pull request
Jan 7, 2025
I unintentionally removed the interval select field on metric alerts when removing the monitor type in #81218 this PR puts it back <img width="1077" alt="Screenshot 2025-01-07 at 9 45 10 AM" src="https://github.com/user-attachments/assets/d249600f-665a-43f3-bcfa-d6f2c567cfdd" /> --------- Co-authored-by: Nate Moore <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the front end for activated alerts as it's being deprecated. I can't merge this until we clean up a couple live alerts but I wanted to get the PRs ready. The gigantic backend counterpart is here #81095
Before
After
