Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(uptime): Prototype allowed response codes config #81215

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanpurkhiser
Copy link
Member

No description provided.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner November 22, 2024 21:23
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 22, 2024
@evanpurkhiser evanpurkhiser marked this pull request as draft November 22, 2024 21:23
Copy link

codecov bot commented Nov 22, 2024

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
8247 4 8243 0
View the top 3 failed tests by shortest run time
Uptime Alert Form handles simple edits
Stack Traces | 0.317s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: Anything, ObjectContaining {"data": ObjectContaining {"url": "https://existing-url.com/test"}}

Number of calls: 0
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:164:24)
Uptime Alert Form can create a new environment
Stack Traces | 0.997s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: Anything, ObjectContaining {"data": ObjectContaining {}}

Number of calls: 0
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:353:24)
Uptime Alert Form can create a new rule
Stack Traces | 2.14s run time
Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: Anything, ObjectContaining {"data": ObjectContaining {"body": "{\"key\": \"value\"}", "environment": "prod", "headers": [["X-Something", "Header Value"]], "intervalSeconds": 60, "method": "POST", "name": "New Uptime Rule", "owner": "user:1", "timeoutMs": 10000, "traceSampling": true, "url": "http://example.com"}}

Number of calls: 0
    at Object.<anonymous> (.../rules/uptime/uptimeAlertForm.spec.tsx:77:24)

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@getsantry
Copy link
Contributor

getsantry bot commented Dec 14, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 14, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Jan 6, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Jan 6, 2025
@evanpurkhiser evanpurkhiser added WIP and removed Stale labels Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components WIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant