chore(similarity): Do not send over 30 system-only frames to seer

[jangjodi]

If an event has no in-app frames and over 30 system frames, return an empty formatted stacktrace string
This will prevent the stacktrace from being sent to seer for the backfill
This will prevent the stacktrace from being sent to seer in ingest after this change is merged #80796
Add metrics for which platform this happens for and new referrer for did_call_seer metric

[JoshFerge]

I think we need to work on the interface of this function. adding another parameter for metrics purposes is a sign that this function get_grouping_info_from_variants is doing too many things and getting bloated.

I would recommend that if this case is reached, we instead raise an exception which we can then catch, call this metric, and set the value to empty string.

you can declare another function which holds this exception logic, which calls get_stacktrace_string. and you can keep the endpoint call the same as we do not need metrics on that call.

IMO,i

[jangjodi]

I think we need to work on the interface of this function. adding another parameter for metrics purposes is a sign that this function get_grouping_info_from_variants is doing too many things and getting bloated.

I would recommend that if this case is reached, we instead raise an exception which we can then catch, call this metric, and set the value to empty string.

you can declare another function which holds this exception logic, which calls get_stacktrace_string. and you can keep the endpoint call the same as we do not need metrics on that call.

IMO,i

Thank you for your review!

[codecov]

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ssues/endpoints/group_similar_issues_embeddings.py	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #80946      +/-   ##
==========================================
+ Coverage   78.48%   78.50%   +0.01%     
==========================================
  Files        7214     7206       -8     
  Lines      319710   319378     -332     
  Branches    44008    43959      -49     
==========================================
- Hits       250937   250715     -222     
+ Misses      62374    62272     -102     
+ Partials     6399     6391       -8     

[armenzg]

This looks very good!

Minor changes and some questions.

[armenzg]

Do we have a test that tracks what happens if you have N exceptions and the sum of their frames is over MAX_FRAMES?

Do we have a test that handles multiple exceptions but only 1 frame is in-app?

[jangjodi]

Thanks for the suggestion! I've added a test for the first case.
Regarding the second case, if we have app data, it's used instead of system data (see here) and we have a test for it here

[JoshFerge]

looks good. thanks for the changes. small comments!

[getsentry-bot]

PR reverted: 4b1562c