-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(releases): Make it easier to read #80820
Conversation
@@ -269,7 +273,7 @@ def update_groups( | |||
status=400, | |||
) | |||
# may not be a release yet | |||
release = status_details.get("inNextRelease") or get_latest_release(projects[0]) | |||
release = status_details.get("inNextRelease") or get_release_to_resolve_by(projects[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more appropriate name for the function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice refactor 👍🏼
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #80820 +/- ##
==========================================
- Coverage 78.39% 78.39% -0.01%
==========================================
Files 7207 7207
Lines 319517 319530 +13
Branches 44005 44008 +3
==========================================
Hits 250498 250498
- Misses 62634 62643 +9
- Partials 6385 6389 +4 |
Follow-up to #80737.