Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(releases): Make it easier to read #80820

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Nov 15, 2024

Follow-up to #80737.

@armenzg armenzg self-assigned this Nov 15, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 15, 2024
@@ -269,7 +273,7 @@ def update_groups(
status=400,
)
# may not be a release yet
release = status_details.get("inNextRelease") or get_latest_release(projects[0])
release = status_details.get("inNextRelease") or get_release_to_resolve_by(projects[0])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more appropriate name for the function.

src/sentry/api/helpers/group_index/update.py Show resolved Hide resolved
@armenzg armenzg marked this pull request as ready for review November 15, 2024 14:40
@armenzg armenzg requested review from a team as code owners November 15, 2024 14:40
Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor 👍🏼

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80820      +/-   ##
==========================================
- Coverage   78.39%   78.39%   -0.01%     
==========================================
  Files        7207     7207              
  Lines      319517   319530      +13     
  Branches    44005    44008       +3     
==========================================
  Hits       250498   250498              
- Misses      62634    62643       +9     
- Partials     6385     6389       +4     

@armenzg armenzg merged commit b3bd7be into master Nov 15, 2024
50 checks passed
@armenzg armenzg deleted the better_semver_fix/releases/armenzg branch November 15, 2024 17:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Releases Product Area: Releases Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants