Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(contexts): Use newly added computed contexts #80579

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented Nov 12, 2024

This PR uses the new computed contexts fields that were added in Relay in getsentry/relay#4239.

Needs: getsentry/relay#4239

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 12, 2024
@iambriccardo iambriccardo added the Do Not Merge Don't merge label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #80579      +/-   ##
==========================================
+ Coverage   78.36%   78.41%   +0.04%     
==========================================
  Files        7206     7221      +15     
  Lines      318720   319746    +1026     
  Branches    43905    44010     +105     
==========================================
+ Hits       249771   250727     +956     
- Misses      62589    62635      +46     
- Partials     6360     6384      +24     

@iambriccardo iambriccardo marked this pull request as ready for review November 18, 2024 14:28
@iambriccardo iambriccardo requested review from a team as code owners November 18, 2024 14:28
@jan-auer
Copy link
Member

jan-auer commented Nov 19, 2024

For a follow-up: Unless there's other dependencies on processed data, these tags could even be extracted in Relay to remove all of the logic here and centralize tag extraction in normalization.

@iambriccardo iambriccardo merged commit 918cbf7 into master Nov 19, 2024
52 checks passed
@iambriccardo iambriccardo deleted the riccardo/feat/change-contexts branch November 19, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Do Not Merge Don't merge Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants