ref(quick-start): Prevent 'complete' tasks from being displayed outside of the completed tasks list #80172
Conversation
github-actions
bot
added
the
Scope: Frontend
| @@ -304,7 +304,6 @@ function TaskGroup({ | |||
| task={task} | |||
| hidePanel={hidePanel} | |||
| showWaitingIndicator={taskKeyForWaitingIndicator === task.task} | |||
| status={task.status} | |||
There was a problem hiding this comment.
when we pass the status here, if it’s 'complete' but not yet 'seen,' the task is displayed with the style of a complete task but does not appear in the completed list. To fix this issue, it’s better to omit the status in this context
There was a problem hiding this comment.
Shouldn't we instead fix the check in the group by completed/non completed tasks in groupTasksByCompletion?
We check there if the task is seen and completed.
| const pendingCompletionSeen = doneTasks.length !== completeTasks.length; | ||
| const allTasksCompleted = allTasks.length === completeTasks.length; |
There was a problem hiding this comment.
It’s better to check for completeTasks instead of doneTasks, as completeTasks are the ones that have already been seen by the user
priscilawebdev
changed the title
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
|
||
| const skipQuickStart = | ||
| !organization.features?.includes('onboarding') || | ||
| (completeTasks.length === allTasks.length && !isActive); | ||
| !organization.features?.includes('onboarding') || (allTasksCompleted && !isActive); |
There was a problem hiding this comment.
Where is this feature flag defined?
I can't find it in our flagpole config
There was a problem hiding this comment.
Ok, i found it, it is only registered in our API
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #80172 +/- ##
=======================================
Coverage 80.47% 80.47%
=======================================
Files 7230 7230
Lines 321215 321214 -1
Branches 20779 20779
=======================================
+ Hits 258488 258489 +1
+ Misses 62324 62322 -2
Partials 403 403 |
…de of the completed tasks list (#80172)
No description provided.