-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(alerts): avoid AttributeError in EventAttributeCondition #79799
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #79799 +/- ##
==========================================
- Coverage 78.09% 78.09% -0.01%
==========================================
Files 7178 7178
Lines 317128 317137 +9
Branches 43722 43726 +4
==========================================
- Hits 247665 247662 -3
- Misses 63118 63124 +6
- Partials 6345 6351 +6 |
@@ -256,7 +256,7 @@ def _handle(cls, path: list[str], event: GroupEvent) -> list[str]: | |||
return [] | |||
|
|||
return [ | |||
getattr(e, path[1]) | |||
str(getattr(e, path[1], None)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this one stringified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mypy gets angry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird, could we run into a problem later on with a string of 'None'
though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced with hasattr
0a60e6a
to
5771b75
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Fixes SENTRY-3H0X