Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(issues): Display attachments as view again #79796

Merged
merged 1 commit into from
Oct 25, 2024
Merged

feat(issues): Display attachments as view again #79796

merged 1 commit into from
Oct 25, 2024

Conversation

scttcper
Copy link
Member

  • removes attachment drawer
  • add wrapper on attachments view

image

@scttcper
feat(issues): Display attachments as view again
6494b31 
- removes attachment drawer
- add wrapper on attachments view
@scttcper scttcper requested a review from a team as a code owner October 25, 2024 22:22
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 25, 2024
@scttcper scttcper enabled auto-merge (squash) October 25, 2024 22:26
@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...views/issueDetails/groupEventAttachments/index.tsx 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #79796      +/-   ##
==========================================
- Coverage   78.41%   77.54%   -0.88%     
==========================================
  Files        7146     7144       -2     
  Lines      315841   315815      -26     
  Branches    43502    43500       -2     
==========================================
- Hits       247667   244892    -2775     
- Misses      61840    64439    +2599     
- Partials     6334     6484     +150

@scttcper scttcper merged commit 7a9e286 into master Oct 25, 2024
44 of 45 checks passed
@scttcper scttcper deleted the scttcper/attachements-wrapper branch October 25, 2024 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roggenkemper roggenkemper roggenkemper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scttcper @roggenkemper