Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onboarding): refetch integrations query on project creation tab refocus #79795

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

ameliahsu
Copy link
Member

@ameliahsu ameliahsu commented Oct 25, 2024

refetch the messaging integrations API query when the project creation page is refocussed

this is really only for the edge case where someone installs an external installation (MS Teams), in which case we don't know when the installation has completed so we can't automatically refresh

@ameliahsu ameliahsu requested a review from a team October 25, 2024 22:15
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 25, 2024
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #79795      +/-   ##
==========================================
- Coverage   78.47%   78.45%   -0.03%     
==========================================
  Files        7137     7142       +5     
  Lines      315778   315947     +169     
  Branches    43439    43485      +46     
==========================================
+ Hits       247807   247862      +55     
- Misses      61651    61760     +109     
- Partials     6320     6325       +5     

@evanpurkhiser
Copy link
Member

I suggested to @ameliahsu that we do this on page re-focus using react-query instead. Since the edge case where they go and add an integration will mean they have to leave the page focus and come back

@ameliahsu ameliahsu changed the title feat(onboarding): add refresh button for messaging integration onboarding on project creation feat(onboarding): refetch integrations query on project creation tab refocus Oct 28, 2024
@ameliahsu ameliahsu merged commit 0478fee into master Oct 28, 2024
46 checks passed
@ameliahsu ameliahsu deleted the mia/proj-creation/refresh branch October 28, 2024 17:46
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants