ref(alerts): Removed unused code #79700
Conversation
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #79700 +/- ##
===========================================
+ Coverage 51.33% 78.46% +27.13%
===========================================
Files 7105 7136 +31
Lines 314270 315622 +1352
Branches 43245 43455 +210
===========================================
+ Hits 161327 247666 +86339
+ Misses 151956 61620 -90336
- Partials 987 6336 +5349 |
| user=owner, | ||
| ) | ||
| AlertRuleExcludedProjects.objects.create(alert_rule=alert, project=other_project) |
There was a problem hiding this comment.
I have to manually create the model instances here since it's been removed from create_alert_rule. This test fails if every single column doesn't have something in it.
We'll be deleting a lot of tables for ACI including these (I think for this feature it's just |
ceorourke
deleted the
ceorourke/rm-include-all-projects-exclude-projects
branch
Sounds good - mostly I wanted to make sure that all the related code is removed, which is easy to test if the models are gone. But we're going to remove all of this, so not a huge deal |
Remove unused options (
include_all_projectsandexcluded_projects) for alert rules - there are no rules in existence that use these and they're not published in the API docs. We'll be addressing what these options intended to cover with ACI anyway, so it's nicer to remove them now so I don't have to remember what to ignore as we make changes.