feat(flags): Add unleashed audit-log provider #79659

aliu39 · 2024-10-24T05:02:35Z

https://github.com/getsentry/team-replay/issues/489

codecov · 2024-10-24T05:07:52Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
22116	1	22115	218

View the top 1 failed tests by shortest run time

tests.sentry.flags.endpoints.test_hooks.OrganizationFlagsHooksEndpointTestCase test_post_invalid_token_control_silo

Stack Traces | 2.68s run time

#x1B[1m#x1B[31m.venv/lib/python3.12............/site-packages/urllib3/connection.py#x1B[0m:196: in _new_conn
    sock = connection.create_connection(
#x1B[1m#x1B[31m.venv/lib/python3.12.../urllib3/util/connection.py#x1B[0m:60: in create_connection
    for res in socket.getaddrinfo(host, port, family, socket.SOCK_STREAM):
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6............/x64/lib/python3.12/socket.py#x1B[0m:976: in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
#x1B[1m#x1B[31mE   socket.gaierror: [Errno -3] Temporary failure in name resolution#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[31m.venv/lib/python3.12........./site-packages/urllib3/connectionpool.py#x1B[0m:789: in urlopen
    response = self._make_request(
#x1B[1m#x1B[31m.venv/lib/python3.12........./site-packages/urllib3/connectionpool.py#x1B[0m:495: in _make_request
    conn.request(
#x1B[1m#x1B[31m.venv/lib/python3.12............/site-packages/urllib3/connection.py#x1B[0m:398: in request
    self.endheaders()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6............/x64/lib/python3.12/http/client.py#x1B[0m:1331: in endheaders
    self._send_output(message_body, encode_chunked=encode_chunked)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6............/x64/lib/python3.12/http/client.py#x1B[0m:1091: in _send_output
    self.send(msg)
#x1B[1m#x1B[.../hostedtoolcache/Python/3.12.6............/x64/lib/python3.12/http/client.py#x1B[0m:1035: in send
    self.connect()
#x1B[1m#x1B[31m.venv/lib/python3.12............/site-packages/urllib3/connection.py#x1B[0m:236: in connect
    self.sock = self._new_conn()
#x1B[1m#x1B[31m.venv/lib/python3.12............/site-packages/urllib3/connection.py#x1B[0m:203: in _new_conn
    raise NameResolutionError(self.host, self, e) from e
#x1B[1m#x1B[31mE   urllib3.exceptions.NameResolutionError: &lt;urllib3.connection.HTTPConnection object at 0x7feb68ce2300&gt;: Failed to resolve 'testserver' ([Errno -3] Temporary failure in name resolution)#x1B[0m

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m
#x1B[1m#x1B[31m.venv/lib/python3.12....../site-packages/requests/adapters.py#x1B[0m:486: in send
    resp = conn.urlopen(
#x1B[1m#x1B[31m.venv/lib/python3.12........./site-packages/urllib3/connectionpool.py#x1B[0m:843: in urlopen
    retries = retries.increment(
#x1B[1m#x1B[31m.venv/lib/python3.12.../urllib3/util/retry.py#x1B[0m:519: in increment
    raise MaxRetryError(_pool, url, reason) from reason  # type: ignore[arg-type]
#x1B[1m#x1B[31mE   urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='testserver', port=80): Max retries exceeded with url: .../launchdarkly/token/wrong/ (Caused by NameResolutionError("&lt;urllib3.connection.HTTPConnection object at 0x7feb68ce2300&gt;: Failed to resolve 'testserver' ([Errno -3] Temporary failure in name resolution)"))#x1B[0m

#x1B[33mDuring handling of the above exception, another exception occurred:#x1B[0m
#x1B[1m#x1B[.../flags/endpoints/test_hooks.py#x1B[0m:236: in test_post_invalid_token_control_silo
    self._test_post_invalid_token()
#x1B[1m#x1B[.../flags/endpoints/test_hooks.py#x1B[0m:205: in _test_post_invalid_token
    response = self.client.post(url, {})
#x1B[1m#x1B[31m.venv/lib/python3.12.............../site-packages/rest_framework/test.py#x1B[0m:295: in post
    response = super().post(
#x1B[1m#x1B[31m.venv/lib/python3.12.............../site-packages/rest_framework/test.py#x1B[0m:209: in post
    return self.generic('POST', path, data, content_type, **extra)
#x1B[1m#x1B[31m.venv/lib/python3.12.............../site-packages/rest_framework/test.py#x1B[0m:233: in generic
    return super().generic(
#x1B[1m#x1B[31m.venv/lib/python3.12.../django/test/client.py#x1B[0m:676: in generic
    return self.request(**r)
#x1B[1m#x1B[31m.venv/lib/python3.12.............../site-packages/rest_framework/test.py#x1B[0m:285: in request
    return super().request(**kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.12.............../site-packages/rest_framework/test.py#x1B[0m:237: in request
    request = super().request(**kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.12.../django/test/client.py#x1B[0m:1092: in request
    self.check_exception(response)
#x1B[1m#x1B[31m.venv/lib/python3.12.../django/test/client.py#x1B[0m:805: in check_exception
    raise exc_value
#x1B[1m#x1B[31m.venv/lib/python3.12.../core/handlers/exception.py#x1B[0m:55: in inner
    response = get_response(request)
#x1B[1m#x1B[31m.venv/lib/python3.12.../core/handlers/base.py#x1B[0m:185: in _get_response
    response = middleware_method(
#x1B[1m#x1B[31m.venv/lib/python3.12.../integrations/django/middleware.py#x1B[0m:107: in sentry_wrapped_method
    return old_method(*args, **kwargs)
#x1B[1m#x1B[.../hybridcloud/apigateway/middleware.py#x1B[0m:28: in process_view
    proxy_response = proxy_request_if_needed(request, view_func, view_kwargs)
#x1B[1m#x1B[.../hybridcloud/apigateway/apigateway.py#x1B[0m:75: in proxy_request_if_needed
    return proxy_request(request, org_id_or_slug, url_name)
#x1B[1m#x1B[.../hybridcloud/apigateway/proxy.py#x1B[0m:100: in proxy_request
    return proxy_region_request(request, region, url_name)
#x1B[1m#x1B[.../hybridcloud/apigateway/proxy.py#x1B[0m:204: in proxy_region_request
    resp = external_request(
#x1B[1m#x1B[31m.venv/lib/python3.12.../site-packages/requests/api.py#x1B[0m:59: in request
    return session.request(method=method, url=url, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.12....../site-packages/requests/sessions.py#x1B[0m:589: in request
    resp = self.send(prep, **send_kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.12....../site-packages/requests/sessions.py#x1B[0m:703: in send
    r = adapter.send(request, **kwargs)
#x1B[1m#x1B[31m.venv/lib/python3.12....../site-packages/requests/adapters.py#x1B[0m:519: in send
    raise ConnectionError(e, request=request)
#x1B[1m#x1B[31mE   requests.exceptions.ConnectionError: HTTPConnectionPool(host='testserver', port=80): Max retries exceeded with url: .../launchdarkly/token/wrong/ (Caused by NameResolutionError("&lt;urllib3.connection.HTTPConnection object at 0x7feb68ce2300&gt;: Failed to resolve 'testserver' ([Errno -3] Temporary failure in name resolution)"))#x1B[0m

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

aliu39 · 2024-10-24T18:59:15Z

src/sentry/flags/unleashed.py

+    )
+    createdBy = serializers.EmailField(required=True)
+
+    createdByUserId = serializers.IntegerField(required=False)


Note to self: unused fields can be dropped, the serializer will just skip them.

getsantry · 2024-11-19T08:00:08Z

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

getsantry · 2024-12-12T08:00:52Z

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

michellewzhang and others added 28 commits October 11, 2024 14:08

feat(flags): add launchdarkly flag log webhook

ec9836d

♻️ types

32b4477

♻️ rm cloneFlag

78e38ae

✅ add post test

73742c6

♻️ add serializer

c1ba7c2

✅ add unit test

9bd73df

✅ add test with real data

f339080

🎨 pass token in url

abf94dc

🎨 fix auth and add case

6bb6b3b

✏️ types:

92b6593

🐛 encode

a05ca87

Update url paramter regex to catch all strings

26bc9d3

♻️ move token parsing into function

e801e2f

✅ more unit tests

c864eaa

🎨 pr comments

6ca780e

🎨 add tags

7f31998

✅ add serialization error output

45acaaf

Fix test coverage

05294fe

Use convert_args

ad8e860

Further prep for feature flag

6739e46

Add feature flag

f64d5c3

✏️ types

5b151be

✅ add tests for actions

20ba6c5

✏️ some more flag actions

32ea8eb

✅ fix test and comment

5ffd0e4

Rename feature flag

8d19425

Camel case endpoint

dbb0d8f

Add camel-case typing

606c5a9

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 24, 2024

vercel bot deployed to Preview October 24, 2024 05:06 View deployment

aliu39 changed the title ~~Initial serializer, supported events, and handle_unleashed_event~~ feat(flags): Add unleashed audit-log provider Oct 24, 2024

vercel bot deployed to Preview October 24, 2024 05:11 View deployment

cmanallen and others added 6 commits October 24, 2024 08:38

Merge branch 'master' into mz/ld-provider

5c97d2b

Use organizations url

77e609d

Initial serializer, supported events, and handle_unleashed_event

7526295

Tweak comments

409791f

Add invalid token tests for wrong org + different silos

ced759c

Make supported actions a constant and link docs

28ad91c

aliu39 commented Oct 24, 2024

View reviewed changes

aliu39 force-pushed the aliu/unleashed-provider branch from 4939443 to 409791f Compare October 24, 2024 19:02

aliu39 added 3 commits October 24, 2024 12:02

Merge branch 'mz/ld-provider' into aliu/unleashed-provider

2f2f8ae

Rename unleashed -> unleash

188ffc6

Rename pt2

5a9d921

vercel bot deployed to Preview October 24, 2024 19:15 View deployment

Refactor providers to separate modules, types to models/exceptions

4cc26bb

vercel bot deployed to Preview October 24, 2024 21:07 View deployment

aliu39 added 2 commits October 24, 2024 16:23

Fix serializer after ngrok test

c593b6b

Add unleash_event_type as a tag

a38b46d

vercel bot deployed to Preview October 24, 2024 23:27 View deployment

Base automatically changed from mz/ld-provider to master October 28, 2024 13:30

getsantry bot added Stale and removed Stale labels Nov 19, 2024

getsantry bot added Stale and removed Stale labels Dec 12, 2024

cmanallen closed this Dec 18, 2024

github-actions bot locked and limited conversation to collaborators Jan 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(flags): Add unleashed audit-log provider #79659

feat(flags): Add unleashed audit-log provider #79659

aliu39 commented Oct 24, 2024 •

edited

Loading

codecov bot commented Oct 24, 2024 •

edited

Loading

aliu39 Oct 24, 2024

getsantry bot commented Nov 19, 2024

getsantry bot commented Dec 12, 2024

feat(flags): Add unleashed audit-log provider #79659

feat(flags): Add unleashed audit-log provider #79659

Conversation

aliu39 commented Oct 24, 2024 • edited Loading

codecov bot commented Oct 24, 2024 • edited Loading

❌ 1 Tests Failed:

aliu39 Oct 24, 2024

Choose a reason for hiding this comment

getsantry bot commented Nov 19, 2024

getsantry bot commented Dec 12, 2024

aliu39 commented Oct 24, 2024 •

edited

Loading

codecov bot commented Oct 24, 2024 •

edited

Loading