Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): Add statsig audit-log provider #79637

Closed
wants to merge 39 commits into from

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Oct 23, 2024

Still work in progress. Will need a formal integration with statig I believe. There's no path that I can find to registering an audit-log hook. Also need to fix the typing issues if statsig is going to return lists of dicts.

Ref: https://github.com/getsentry/team-replay/issues/490

@cmanallen cmanallen requested review from a team as code owners October 23, 2024 20:52
@cmanallen cmanallen changed the base branch from master to mz/ld-provider October 23, 2024 20:53
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@                Coverage Diff                 @@
##           mz/ld-provider   #79637      +/-   ##
==================================================
- Coverage           78.39%   78.28%   -0.12%     
==================================================
  Files                7131     7126       -5     
  Lines              314930   313125    -1805     
  Branches            43275    51082    +7807     
==================================================
- Hits               246903   245132    -1771     
+ Misses              61717    61609     -108     
- Partials             6310     6384      +74     

src/sentry/flags/providers.py Outdated Show resolved Hide resolved
tests/sentry/flags/providers/test_statsig.py Outdated Show resolved Hide resolved
Base automatically changed from mz/ld-provider to master October 28, 2024 13:30
@getsantry
Copy link
Contributor

getsantry bot commented Nov 19, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 19, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 12, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 12, 2024
@cmanallen cmanallen closed this Dec 18, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants