devenv: upgrade colima to 0.7.5 #78881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
…or newer limactl version
joshuarli
force-pushed
the
devenv-upgrade-colima-part-2
branch
from
6bb650d to
868d5a0
Compare
joshuarli
commented
Oct 11, 2024
devenv/config.ini
Outdated
| @@ -1,5 +1,5 @@ | |||
| [devenv] | |||
| minimum_version = 1.10.2 | |||
| minimum_version = 1.11.0 | |||
There was a problem hiding this comment.
this is a noop until minimum_version is implemented in 1.12.0 (getsentry/devenv#163)
but... 1.11.0 is a hard minimum requirement otherwise the newer colima won't be installed as a shim, and the newer limactl from homebrew can't be installed either
think we do need something in sync.py in the interim to lay the chicken egg
asottile-sentry
approved these changes
Oct 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #78881 +/- ##
===========================================
+ Coverage 52.16% 78.42% +26.25%
===========================================
Files 7158 7139 -19
Lines 315942 315246 -696
Branches 43561 43338 -223
===========================================
+ Hits 164814 247218 +82404
+ Misses 149482 61707 -87775
- Partials 1646 6321 +4675 |
|
actually, let's wait on merging this for a couple days so people can naturally update via |
sure thing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see getsentry/devenv#146