Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing(interfaces): Type contexts #78768

Closed
wants to merge 1 commit into from
Closed

Conversation

armenzg
Copy link
Member

@armenzg armenzg commented Oct 8, 2024

No description provided.

@armenzg armenzg requested a review from a team October 8, 2024 15:48
@armenzg armenzg self-assigned this Oct 8, 2024
@armenzg armenzg requested review from a team as code owners October 8, 2024 15:48
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 8, 2024
@@ -108,7 +108,7 @@ def __setattr__(self, name, value):
self._data[name] = value

@classmethod
def to_python(cls, data, datapath: DataPath | None = None):
def to_python(cls: Any, data: dict[str, Any], **kwargs: Any) -> dict[str, Any] | None:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match the signature in Contexts.

@@ -108,7 +108,7 @@ def __setattr__(self, name, value):
self._data[name] = value

@classmethod
def to_python(cls, data, datapath: DataPath | None = None):
def to_python(cls: Any, data: dict[str, Any], **kwargs: Any) -> dict[str, Any] | None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cls should never be annotated -- it will receive an automatic type[Self] annotation

@armenzg armenzg marked this pull request as draft October 24, 2024 12:25
@getsantry
Copy link
Contributor

getsantry bot commented Nov 15, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Nov 15, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 8, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added Stale and removed Stale labels Dec 8, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 31, 2024

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 31, 2024
@getsantry getsantry bot closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants