Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(alerts): Define anomaly detection connection pool once #78655

Closed
wants to merge 3 commits into from
Closed

ref(alerts): Define anomaly detection connection pool once #78655

wants to merge 3 commits into from

Conversation

ceorourke
Copy link
Member

We had seer_anomaly_detection_connection_pool defined in a few places, this just moves it to be defined once in utils.py and imports it as needed.

Some tests will fail until I can rebase on top of #78652

@ceorourke ceorourke requested a review from a team as a code owner October 4, 2024 21:48
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 4, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
329 4 325 9
View the top 3 failed tests by shortest run time 
 tests.sentry.incidents.endpoints.test_organization_alert_rule_anomalies
Stack Traces | 0s run time 
No failure message available

 tests.sentry.incidents.endpoints.test_organization_alert_rule_details
Stack Traces | 0s run time 
No failure message available

 tests.sentry.incidents.endpoints.test_organization_alert_rule_index
Stack Traces | 0s run time 
No failure message available

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@ceorourke ceorourke force-pushed the ceorourke/ref-anomaly-detection-connection-pool branch from 8c8fa19 to 0faa07e Compare October 4, 2024 22:09
saponifi3d
saponifi3d reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests will fail until I can rebase on top of #78652

since that's merged, is this good to be rebased to re-run ci? i noticed a couple other failures in there that might be unrelated.

src/sentry/seer/anomaly_detection/delete_rule.py
@@ -26,6 +21,8 @@ def delete_rule_in_seer(alert_rule: "AlertRule") -> bool:
"""
Send a request to delete an alert rule from Seer. Returns True if the request was successful.
"""
from sentry.seer.anomaly_detection.utils import SEER_ANOMALY_DETECTION_CONNECTION_POOL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a regular import instead of type checking only? (It looks like it's being used as a default value on line 36).

@getsantry
Copy link
Contributor

getsantry bot commented Oct 29, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 29, 2024
@ceorourke ceorourke closed this Oct 29, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@saponifi3d saponifi3d saponifi3d left review comments

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ceorourke @saponifi3d