ref(relay): Write project config revision to Redis #75523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: src/sentry/relay/projectconfig_cache/redis.py
Did you find this useful? React with a 👍 or 👎 |
github-actions
bot
added
the
Scope: Backend
Dav1dde
commented
Aug 2, 2024
| @@ -63,6 +68,11 @@ def get(self, public_key): | |||
| rv = zstandard.decompress(rv_b).decode() | |||
| except (TypeError, zstandard.ZstdError): | |||
| # assume raw json | |||
| pass | |||
| rv = rv_b | |||
There was a problem hiding this comment.
Drive by fix ... That would have just blown up before because rv is not defined.
jjbayer
approved these changes
Aug 2, 2024
Dav1dde
commented
Aug 2, 2024
| metrics.incr("relay.projectconfig_cache.write", amount=len(configs), tags={"action": "set"}) | ||
|
|
||
| # Note: Those are multiple pipelines, one per cluster node | ||
| p = self.cluster.pipeline() | ||
| p = self.cluster.pipeline(transaction=False) |
There was a problem hiding this comment.
There is no need for this pipeline to be transactional (default value), all keys are independent.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75523 +/- ##
==========================================
+ Coverage 77.34% 78.22% +0.88%
==========================================
Files 6819 6821 +2
Lines 302757 302954 +197
Branches 52110 52139 +29
==========================================
+ Hits 234159 236991 +2832
+ Misses 62055 59593 -2462
+ Partials 6543 6370 -173
|
Dav1dde
added a commit
to getsentry/relay
that referenced
this pull request
Aug 6, 2024
Checks the 'new' revision key before actually loading and parsing the project config. Revision introduced here: getsentry/sentry#75523 Change is backwards compatible, if the key is missing the check is simply skipped. I was considering propagating the information whether something was refreshed or a fresh fetch through the state channel, but after review and consideration, I don't think that is useful information, we still have to reset a bunch of internal state and move the project out of the `in flight` status. All if which we already do, the only thing we could change is skipping the assignment of the project info contained in the project fetch state (because that's the same state as the old), but this is already only an `Arc`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: getsentry/relay#3887
Writes the revision to Redis as a separate key. Allowing for optimized reads by revision.
#skip-changelog