feat(performance): Implement new breadcrumb view in trace drawer #74243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
Okay so this allows the new UI to appear in the trace explorer, but with a few caveats. The controls look a bit different than in the drawer and it has a fixed height and inner scroll.
This was sort of a rush job since I start vacation soon and wanted there to at least be an option for the team while I'm out but I'm not super pleased with this user experience, since we still have the inner scroll that the whole redesign pointedly removes.
It also creates some code duplication since the buttons used in the drawer are similar, but not the same, since the controls weren't designed with the trace drawer in mind. I tried to reduce the duplication with a wrapping hook, but it's a bit messy.
An alternative
IF we're open to the idea of popping open the drawer experience, we can get away with dropping it in really easily with no code smell:
This would make the two components identical, at the cost of covering the rest of the trace drawer with the global drawer when the user prompts it. Not sure how people feel about it, though so I'll leave this PR up for discussion.
If we decide the alternative is a better call, please close out this PR.
Feel free to modify this PR to make appropriate changes as we see fit since I'll be away for a bit.