ref(rules): Fix task name for delayed rule processing #70831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
schew2381
approved these changes
May 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70831 +/- ##
=======================================
Coverage 80.01% 80.02%
=======================================
Files 6504 6505 +1
Lines 290769 290781 +12
Branches 50119 50119
=======================================
+ Hits 232666 232684 +18
+ Misses 57666 57660 -6
Partials 437 437
|
saponifi3d
approved these changes
May 14, 2024
| @@ -73,6 +73,7 @@ def callback(self, buffer_hook_event: BufferHookEvent, data: RedisBuffer) -> boo | |||
| try: | |||
| callback = self._registry[buffer_hook_event] | |||
| except KeyError: | |||
| logger.info("buffer_hook_event.missing", extra={"key_name": buffer_hook_event.value}) | |||
There was a problem hiding this comment.
nit: might be nice to make this an error log instead of an info log, and pass the exception.
There was a problem hiding this comment.
👍 I'll change it in a separate PR, really wanna get this out to do testing
ceorourke
added a commit
that referenced
this pull request
May 14, 2024
Follow up from #70831 (comment) to make this raise an exception rather than just log an error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task for processing delayed rules wasn't imported into
CELERY_IMPORTSand the name was incorrect - this fixes both and adds a log message if the buffer hook registry isn't working as expected.