chore(hybridcloud) Enable stricter types on more modules #70818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move a few more modules into the stricter allow list.
github-actions
bot
added
the
Scope: Backend
tests/sentry/types/test_region.py
Outdated
| @@ -68,11 +69,11 @@ class RegionDirectoryTest(TestCase): | |||
|
|
|||
| @staticmethod | |||
| @contextmanager | |||
| def _in_global_state(directory: RegionDirectory): | |||
| def _in_global_state(directory: RegionDirectory) -> Any: | |||
There was a problem hiding this comment.
Generator[None, None, None]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70818 +/- ##
===========================================
+ Coverage 57.71% 80.02% +22.30%
===========================================
Files 6498 6504 +6
Lines 290390 290775 +385
Branches 50068 50119 +51
===========================================
+ Hits 167603 232679 +65076
+ Misses 122346 57659 -64687
+ Partials 441 437 -4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move a few more modules into the stricter allow list.