-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(performance): queues module destination search #70816
feat(performance): queues module destination search #70816
Conversation
…nd fixes some minor ui bugs in samples panel
…ueues-module-destination-search
const sort = | ||
decodeSorts(query[QueryParameterNames.DOMAINS_SORT]).filter(isAValidSort).at(0) ?? | ||
DEFAULT_SORT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is placeholder for now as I'm working on completing the table sorting. (DOMAINS_SORT
will be replaced to something more appropriate). There's a few more placeholders below that will also be taken care of in a future pr.
Can remove from this pr if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small comments, looks good to me
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Updates the search bar in the Queues module landing page to fully function:
messaging.destination.name
tag/columnThere's some "sort" and "time spent" placeholders in this pr that doesn't need to be included (sorry). I have a subsequent pr to complete those, but I can pull out of this pr if needed.