snuba(devexp): Migrate meta queries to use storage direct queries #70794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #70794 +/- ##
===========================================
- Coverage 88.30% 80.00% -8.30%
===========================================
Files 2861 6507 +3646
Lines 178774 290843 +112069
Branches 31900 50129 +18229
===========================================
+ Hits 157862 232698 +74836
- Misses 20910 57713 +36803
- Partials 2 432 +430
|
volokluev
reviewed
May 13, 2024
| OrderBy(Column("project_id"), Direction.ASC), | ||
| OrderBy(Column(column_name), Direction.ASC), | ||
| ] | ||
| if in_random_rollout("sentry-metrics.metrics-layer.use-storage-direct-meta-queries"): |
There was a problem hiding this comment.
where you able to run the CI tests using the storage-direct-meta-queries on?
There was a problem hiding this comment.
Tested on CI with flag enabled 👍
volokluev
approved these changes
May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Now that snuba supports querying a storage directly (as opposed to querying an entity), meta queries are a great candidate to take advantage of this. All meta queries are executed through the metrics layer, therefore these changes will apply to any product (right now just DDM) running meta queries. The main change is switching out
EntityforStoragein thematchclause of the query.Testing
This change is guarded behind the sentry option:
sentry-metrics.metrics-layer.use-storage-direct-meta-queriesand will be slowly rolled out + monitored.