feat(insights): add analytics to database sample panel #70769
Conversation
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 2.94kB ⬆️
|
KevinL10
changed the title
KevinL10
force-pushed
the
kevinliu/feat/sample-panel-analytics
branch
from
0408029 to
677528a
Compare
There was a problem hiding this comment.
Changes are looking good, but i'm curious about something!
Will we be able to gather stats relative to the amount of people that are on the page as well? Knowing the total amount of clicks on samples are helpful so we can compare between modules. But also knowing what proportion of people that enter a module arrive to a sample is also an interesting question to answer.
Answering this question directly might not be too feasible, but perhaps some other metric could help us with this!
|
Agree it would be good to have proportion of module visits that arrive to at least 1 sample. For now, we have the total number of people who visit the module itself, so we have a rough estimate of the average # of sample panels opened per page visit. I'll see if there are any other similar metrics we can gather. |
There was a problem hiding this comment.
looking good overall! Feel free to address my comments as you see fit.
Personally i'm not a fan of adding a moduleName prop everywhere, it doesn't really dictate any difference in component behaviour and its used purely for analytics. We could consider determining the name from the URL. I'm cool if we think about this later too!
| @@ -67,6 +68,7 @@ type Props = { | |||
| avg: number; | |||
| data: SpanTableRow[]; | |||
| isLoading: boolean; | |||
| moduleName: string; | |||
There was a problem hiding this comment.
We have a moduleName type here, that we should probably use instead of string
https://github.com/getsentry/sentry/blob/master/static/app/views/starfish/types.tsx#L13
Although its missing a bunch of modules, so we could extend that.
There was a problem hiding this comment.
+1 to this! If you add the missing modules to ModuleName and use ModuleName instead of strings that'd be great 👍🏻
| @@ -67,6 +68,7 @@ type Props = { | |||
| avg: number; | |||
| data: SpanTableRow[]; | |||
| isLoading: boolean; | |||
| moduleName: string; | |||
There was a problem hiding this comment.
+1 to this! If you add the missing modules to ModuleName and use ModuleName instead of strings that'd be great 👍🏻
|
thanks all! changed to ModuleName type and added the other modules. May consider inferring module from URL later on. |
Continuation of #70769. Adds analytics to the span sample panel to track: - How often the panels are opened - How often spans are clicked - How often “Try different samples” is clicked - How often specific filters are interacted with Modules to add analytics to: - [x] HTTP - [x] Database - [x] Cache - [x] Queues - [x] Screen Loads - [x] App Starts - [x] Resources Note: Web Vitals does not have a sample panel --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Continuation of #70769. Adds analytics to the span sample panel to track: - How often the panels are opened - How often spans are clicked - How often “Try different samples” is clicked - How often specific filters are interacted with Modules to add analytics to: - [x] HTTP - [x] Database - [x] Cache - [x] Queues - [x] Screen Loads - [x] App Starts - [x] Resources Note: Web Vitals does not have a sample panel --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Adds analytics to the span sample panel to track:
This PR adds analytics to database only as a first step. I'll be adding analytics to the remaining modules in the next PR.