Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(chartcuterie): Revert Style Changes #70558

Merged
merged 2 commits into from
May 8, 2024

Conversation

iamrajjoshi
Copy link
Member

This reverts 1354478 and 173b690

@iamrajjoshi iamrajjoshi self-assigned this May 8, 2024
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 8, 2024
@sentaur-athena
Copy link
Member

Do we know what caused the failure? Or just reverting because the timing matches

@iamrajjoshi
Copy link
Member Author

Do we know what caused the failure? Or just reverting because the timing matches

We are trying to see if this helps

@iamrajjoshi iamrajjoshi enabled auto-merge (squash) May 8, 2024 23:26
Copy link

codecov bot commented May 8, 2024

Bundle Report

Bundle size has no change ✅

@ellisonmarks
Copy link
Contributor

Do we know what caused the failure? Or just reverting because the timing matches

I believe the chartcuterie deployment is crashing because it's encountering URLSearchParams in https://sentry.io/_chartcuterie-config.js. Presumably that wasn't there before this change?

@iamrajjoshi iamrajjoshi disabled auto-merge May 8, 2024 23:28
@iamrajjoshi iamrajjoshi enabled auto-merge (squash) May 8, 2024 23:47
@iamrajjoshi iamrajjoshi merged commit 8ff17a9 into master May 8, 2024
42 checks passed
@iamrajjoshi iamrajjoshi deleted the raj/charcuterie/revert-changes branch May 8, 2024 23:59
@sentaur-athena
Copy link
Member

@ellisonmarks oh I thought this PR fixed it. getsentry/chartcuterie#149
Just checked the logs though and seems like the issue is still going on.

evanpurkhiser pushed a commit that referenced this pull request May 9, 2024
@iamrajjoshi iamrajjoshi added the Trigger: Revert Add to a merged PR to revert it (skips CI) label May 9, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 995df95

getsentry-bot added a commit that referenced this pull request May 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants