OPS-5392 add datadog event support #70399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
nirajdewani
changed the title
iambriccardo
reviewed
May 7, 2024
Co-authored-by: Riccardo Busetti <[email protected]>
anonrig
reviewed
May 8, 2024
fpacifici
requested changes
May 8, 2024
mwarkentin
approved these changes
May 13, 2024
nirajdewani
dismissed
fpacifici’s stale review
Already made the required changes.
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
## Description <!-- Describe your PR here. --> I'd like to add support for [Datadog Events](https://docs.datadoghq.com/service_management/events/guides/dogstatsd/). Pasting context from [OPS-5392](https://getsentry.atlassian.net/browse/OPS-5392): > Currently back pressure sends metrics to Datadog ([https://app.datadoghq.com/dashboard/qnx-z63-3di/backpressure-monitoring](https://app.datadoghq.com/dashboard/qnx-z63-3di/backpressure-monitoring?fromUser=false&refresh_mode=paused&view=spans&from_ts=1709132829007&to_ts=1709137896990&live=false)). We should send datadog events instead (or as well): https://docs.datadoghq.com/service_management/events/ This would enable us to do things like: >- Trigger DD monitors for alerting purposes (eg. notifying slack / PagerDuty) >- overlay events on top of dashboard widgets >- add tags to events to support analysis / grouping ## (Potential) To Do Added a unit test; please let me know if/how I can test this better. [OPS-5392]: https://getsentry.atlassian.net/browse/OPS-5392?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: Riccardo Busetti <[email protected]>
nirajdewani
added a commit
that referenced
this pull request
May 21, 2024
### Description Now that sentry [supports](#70399) Datadog events, \ updating backpressure code to generate events as well (in addition to metrics). ### Next steps - Send events using dogshell - Update event body if the need be
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to add support for Datadog Events.
Pasting context from OPS-5392:
(Potential) To Do
Added a unit test; please let me know if/how I can test this better.