Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(feedback): rm spam UI feature flag #70359

Merged
merged 2 commits into from
May 14, 2024
Merged

chore(feedback): rm spam UI feature flag #70359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb0929
chore(feedback): rm spam UI feature flag
michellewzhang May 6, 2024
557b19b
Merge remote-tracking branch 'origin/master' into mz/spam-ff-be
michellewzhang May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/sentry/conf/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1939,8 +1939,6 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
"organizations:user-feedback-ingest": False,
# Use ReplayClipPreview inside the User Feedback Details panel
"organizations:user-feedback-replay-clip": False,
# Enable User Feedback spam auto filtering feature UI
"organizations:user-feedback-spam-filter-ui": False,
Comment on lines -1942 to -1943
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does spam filter work on self hosted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should, @JoshFerge just told me to remove the flags😶‍🌫️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i need to write the docs for it still, but for now self hosted can mark things manually as spam

# Enable User Feedback spam auto filtering feature ingest
"organizations:user-feedback-spam-filter-ingest": False,
# Enable User Feedback spam auto filtering feature actions
Expand Down
1 change: 0 additions & 1 deletion src/sentry/features/temporary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,6 @@ def register_temporary_features(manager: FeatureManager):
manager.add("organizations:user-feedback-replay-clip", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
manager.add("organizations:user-feedback-spam-filter-ingest", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)
manager.add("organizations:user-feedback-spam-filter-actions", OrganizationFeature, FeatureHandlerStrategy.OPTIONS)
manager.add("organizations:user-feedback-spam-filter-ui", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
manager.add("organizations:user-feedback-ui", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
manager.add("organizations:user-feedback-event-link-ingestion-changes", OrganizationFeature, FeatureHandlerStrategy.OPTIONS)
manager.add("organizations:view-hierarchies-options-dev", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
Expand Down
Loading