Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully enable reprocessing-v2 (backend) #69204

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

Swatinem
Copy link
Member

This fully enables the feature by simply removing all the checks and early returns for the feature flag.


Split out from #68412

This fully enables the feature by simply removing all the checks and early returns for the feature flag.
@Swatinem Swatinem self-assigned this Apr 18, 2024
@Swatinem Swatinem requested a review from a team April 18, 2024 16:23
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.70%. Comparing base (dd70023) to head (1645d4f).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #69204      +/-   ##
==========================================
- Coverage   80.02%   79.70%   -0.33%     
==========================================
  Files        6505     6425      -80     
  Lines      290784   285080    -5704     
  Branches    50109    49118     -991     
==========================================
- Hits       232710   227210    -5500     
+ Misses      57637    57433     -204     
  Partials      437      437              
Files Coverage Δ
src/sentry/api/endpoints/event_reprocessable.py 90.47% <ø> (+2.97%) ⬆️
src/sentry/api/endpoints/group_reprocessing.py 47.61% <ø> (+1.78%) ⬆️

... and 1533 files with indirect coverage changes

@getsantry getsantry bot added the Stale label May 11, 2024
@getsantry
Copy link
Contributor

getsantry bot commented May 11, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@loewenheim loewenheim removed the Stale label May 13, 2024
@loewenheim loewenheim enabled auto-merge (squash) May 13, 2024 12:46
@loewenheim loewenheim merged commit 5ce6705 into master May 13, 2024
50 checks passed
@loewenheim loewenheim deleted the swatinem/enable-reprocessing2 branch May 13, 2024 13:11
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants