Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(metrics-extraction): Reduce cold cache peak w/ rolling cache #68727

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

k-fish
Copy link
Member

@k-fish k-fish commented Apr 11, 2024

Summary

This splits up the cache into 6 chunks and spreads out the ttl so at any one extraction only part of the cache is cold.

This splits up the cache into 6 chunks and spreads out the ttl so at any one extraction only part of the cache is cold.
@k-fish k-fish requested a review from wmak April 11, 2024 18:41
@k-fish k-fish requested a review from a team as a code owner April 11, 2024 18:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Bundle Report

Changes will increase total bundle size by 9.79kB ⬆️

Bundle name Size Change
sentry-webpack-bundle-array-push 26.3MB 9.79kB ⬆️

@k-fish k-fish enabled auto-merge (squash) April 11, 2024 18:56
@k-fish k-fish merged commit 489a1d0 into master Apr 11, 2024
48 checks passed
@k-fish k-fish deleted the ref/metrics-extraction-bulk-rolling-cache branch April 11, 2024 19:20
Copy link

sentry-io bot commented Apr 11, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ KeyError: 2 query_subscription_consumer_process_message View Issue
  • ‼️ KeyError: 0 get_project_config View Issue

Did you find this useful? React with a 👍 or 👎

@k-fish k-fish added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Apr 11, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 547c13a

getsentry-bot added a commit that referenced this pull request Apr 11, 2024
k-fish added a commit that referenced this pull request Apr 12, 2024
k-fish added a commit that referenced this pull request Apr 12, 2024
> This splits up the cache into 6 chunks and spreads out the ttl so at
any one extraction only part of the cache is cold.

See #68727
c298lee pushed a commit that referenced this pull request Apr 12, 2024
)

### Summary
This splits up the cache into 6 chunks and spreads out the ttl so at any
one extraction only part of the cache is cold.
c298lee pushed a commit that referenced this pull request Apr 12, 2024
c298lee pushed a commit that referenced this pull request Apr 12, 2024
> This splits up the cache into 6 chunks and spreads out the ttl so at
any one extraction only part of the cache is cold.

See #68727
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants