feat(data-consent): Add region check to data consent option #68315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Bundle ReportChanges will decrease total bundle size by 719 bytes ⬇️
|
vartec
approved these changes
Apr 19, 2024
| if not request.access.has_scope("org:billing"): | ||
| raise serializers.ValidationError("You do not have permission to change this option") | ||
|
|
||
| if get_local_region().name != "us": |
There was a problem hiding this comment.
Beyond scope of this PR, but we probably should make region IDs into some kind of StrEnum or something like that, so it would use RegionEnum.US instead of "us".
| @@ -326,6 +327,23 @@ def validate_projectRateLimit(self, value): | |||
| ) | |||
| return value | |||
|
|
|||
| def validate_aggregatedDataConsent(self, value): | |||
There was a problem hiding this comment.
style nit: what's with the camel-case?
🐍
mrduncan
added a commit
that referenced
this pull request
Apr 19, 2024
This is a temporary fix to disable AI suggested solution in the DE region. A separate PR will update organization settings to disable the option for regions which do not support AI suggested solution. This will all be eventually replaced with Autofix. We'll incorporate AI suggested solution into the same changes we're making in #68315
MichaelSun48
pushed a commit
that referenced
this pull request
Apr 25, 2024
This is a temporary fix to disable AI suggested solution in the DE region. A separate PR will update organization settings to disable the option for regions which do not support AI suggested solution. This will all be eventually replaced with Autofix. We'll incorporate AI suggested solution into the same changes we're making in #68315
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a check for the region, since the genAIConsent option is limited to those organizations in the US region