Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(relocation): Handle expired superuser gracefully #62243

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix(relocation): Handle expired superuser gracefully #62243

merged 1 commit into from
Dec 22, 2023

Conversation

azaslavsky
Copy link
Contributor

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Dec 21, 2023
@azaslavsky azaslavsky marked this pull request as ready for review December 21, 2023 22:59
@codecov Codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (bbd0230) 81.22% compared to head (747b191) 81.25%.
Report is 106 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #62243      +/-   ##
==========================================
+ Coverage   81.22%   81.25%   +0.02%     
==========================================
  Files        5190     5195       +5     
  Lines      229282   229791     +509     
  Branches    39615    39701      +86     
==========================================
+ Hits       186234   186713     +479     
- Misses      37355    37358       +3     
- Partials     5693     5720      +27
Files Coverage Δ
src/sentry/api/endpoints/relocations/index.py 94.21% <60.00%> (-1.52%) ⬇️

... and 87 files with indirect coverage changes

@azaslavsky azaslavsky merged commit cbfdce1 into master Dec 22, 2023
50 of 51 checks passed
@azaslavsky azaslavsky deleted the az/expired-superuser branch December 22, 2023 00:45
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hubertdeng123 hubertdeng123 hubertdeng123 approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azaslavsky @hubertdeng123