feat(relocation): Enable globally for superusers #61822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Superusers (aka admins) will no be able to hit the relocation endpoint successfully in all deployments. The `relocation:enabled` flag, and the `relocation.enabled` option that controls it, will instead refer only to the self-serve endpoint, which will remain contained to the test region for now. This means that admins can now trigger relocations in any region for any user, and are not throttled when they do so. Regular users may only trigger relocations for themselves in regions where `relocations.enabled` is set to `True`, and are subject to the global daily throttles. Issue: getsentry/team-ospo#214
azaslavsky
force-pushed
the
az/open-post-endpoint
branch
from
b9acd7a
to
137e966
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #61822 +/- ##
==========================================
- Coverage 81.20% 81.20% -0.01%
==========================================
Files 5187 5187
Lines 228307 228390 +83
Branches 38294 38313 +19
==========================================
+ Hits 185406 185460 +54
- Misses 37269 37292 +23
- Partials 5632 5638 +6
|
hubertdeng123
approved these changes
Dec 15, 2023
| ) | ||
|
|
||
| # Only superusers can start relocations for other users. |
There was a problem hiding this comment.
Good to be extra safe here, but just thinking if this would ever be a problem. Since the only time I'm thinking someone is allowed to enter in the owner of a relocation is in the admin panel
| except KeyError: | ||
| return Response( | ||
| {"detail": ERR_UNKNOWN_RELOCATION_STATUS.substitute(status=status_str)}, | ||
| status=400, | ||
| status=status.HTTP_400_BAD_REQUEST, |
There was a problem hiding this comment.
nice catches here on using status
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superusers (aka admins) will now be able to hit the relocation endpoint successfully in all deployments. The
relocation:enabledflag, and therelocation.enabledoption that controls it, will instead refer only to the self-serve endpoint, which will remain contained to the test region for now.This means that admins can now trigger relocations in any region for any user, and are not throttled when they do so. Regular users may only trigger relocations for themselves in regions where
relocations.enabledis set toTrue, and are subject to the global daily throttles.Issue: getsentry/team-ospo#214