Implement separate thresholds route #58202
Conversation
github-actions
bot
added
the
Scope: Frontend
nhsiehgit
force-pushed
the
implement_separate_thresholds_route
branch
from
ccde633 to
e84bae0
Compare
github-actions
bot
added
the
Scope: Backend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
nhsiehgit
changed the title
nhsiehgit
force-pushed
the
implement_separate_thresholds_route
branch
from
3443faa to
539f25f
Compare
| @@ -1470,6 +1470,30 @@ function buildRoutes() { | |||
| </Route> | |||
| </Fragment> | |||
| ); | |||
| const releaseThresholdRoutes = ( | |||
There was a problem hiding this comment.
🤷
Maybe this doesn't need to be a separate const, but figured it'd help differentiate responsibility
|
|
||
| function ReleaseThresholdList({router, organization}: Props) { | ||
| const hasV2ReleaseUIEnabled = organization.features.includes('release-ui-v2'); | ||
| if (!hasV2ReleaseUIEnabled) { |
There was a problem hiding this comment.
Let me know if there's a better way to redirect on component mount than this 🤷
There was a problem hiding this comment.
probably in a useEffect with just the org as a dependnecy
| ); | ||
| } | ||
|
|
||
| export default withProjects(withOrganization(withPageFilters(ReleaseThresholdList))); |
There was a problem hiding this comment.
we're trying to use hooks on new components instead of HoC. i think these should all exist like usePageFilters
There was a problem hiding this comment.
Oh awesome.
Love that direction.
will update
Separate flagged threshold routing has now been completed in [this PR](#58202) Most recent updates resolve rebase discrepancies and re-implement the thresholds list view with appropriate page filters and redirects https://github.com/getsentry/sentry/assets/6186377/0cd52029-ed07-45a6-a9ce-cf6b5e6b0924
Implements a separate route for release thresholds and modifies the header for the release index page.
Oct-16-2023.16-23-28.mp4
All changes/routes are hidden behind an org feature flag.
if flag is not set, then release trheshold page will redirect to the release page.
Oct-16-2023.16-20-21.mp4