Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(COGS): Add UsageAccumulator and use in Metrics Indexer #57524

Closed
wants to merge 6 commits into from

Conversation

rahul-kumar-saini
Copy link
Contributor

Overview

  • Adds UsageAccumulator from the usage-accountant library
  • Uses said UsageAccumulator class to start recording consumer throughput usage for Metrics Indexer consumer
  • What this will do is start publishing throughput (in bytes) of the indexer consumer to a topic shared-resources-usage to start sending usage data for COGS

Notes

  • Probably depends on some sort of ops repo change to use kafka-small as the cluster for this topic

Additional Context

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 4, 2023
@rahul-kumar-saini rahul-kumar-saini changed the title feat(COGS): Add UsageAccountant for Metrics Indexer feat(COGS): Add UsageAccumulator and use in Metrics Indexer Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #57524 (4105d72) into master (a5040a7) will decrease coverage by 0.01%.
Report is 10 commits behind head on master.
The diff coverage is 65.15%.

@@            Coverage Diff             @@
##           master   #57524      +/-   ##
==========================================
- Coverage   78.92%   78.91%   -0.01%     
==========================================
  Files        5121     5122       +1     
  Lines      221306   221435     +129     
  Branches    37487    37520      +33     
==========================================
+ Hits       174669   174755      +86     
- Misses      41013    41051      +38     
- Partials     5624     5629       +5     
Files Coverage Δ
src/sentry/conf/server.py 89.81% <100.00%> (+0.01%) ⬆️
src/sentry/interfaces/stacktrace.py 69.81% <100.00%> (+0.13%) ⬆️
src/sentry/options/defaults.py 100.00% <100.00%> (ø)
...tatic/app/components/groupPreviewTooltip/utils.tsx 100.00% <ø> (ø)
static/app/views/replays/detail/console/index.tsx 0.00% <ø> (ø)
...ic/app/views/replays/detail/domMutations/index.tsx 0.00% <ø> (ø)
static/app/views/replays/detail/network/index.tsx 0.00% <ø> (ø)
src/sentry/stacktraces/functions.py 96.25% <96.00%> (-0.05%) ⬇️
src/sentry/utils/kafka.py 45.45% <50.00%> (+1.01%) ⬆️
...c/sentry/sentry_metrics/consumers/indexer/batch.py 90.82% <66.66%> (-0.66%) ⬇️
... and 1 more

... and 10 files with indirect coverage changes

@getsantry
Copy link
Contributor

getsantry bot commented Oct 26, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 26, 2023
@getsantry getsantry bot closed this Nov 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant