rename screen_load and app_start in ModuleName

getsentry · May 15, 2024 · db27a58 · db27a58
1 parent 168d3af
commit db27a58
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/static/app/views/performance/mobile/appStarts/screenSummary/index.tsx b/static/app/views/performance/mobile/appStarts/screenSummary/index.tsx
@@ -193,7 +193,7 @@ export function ScreenSummary() {
                   ...(deviceClass ? {[SpanMetricsField.DEVICE_CLASS]: deviceClass} : {}),
                 }}
                 groupId={spanGroup}
-                moduleName={ModuleName.STARTUP}
+                moduleName={ModuleName.APP_START}
                 transactionName={transactionName}
                 spanDescription={spanDescription}
                 spanOp={spanOp}

diff --git a/static/app/views/performance/mobile/screenload/screenLoadSpans/index.tsx b/static/app/views/performance/mobile/screenload/screenLoadSpans/index.tsx
@@ -211,7 +211,7 @@ function ScreenLoadSpans() {
               {spanGroup && (
                 <SpanSamplesPanel
                   groupId={spanGroup}
-                  moduleName={ModuleName.SCREEN}
+                  moduleName={ModuleName.SCREEN_LOAD}
                   transactionName={transactionName}
                   spanDescription={spanDescription}
                   onClose={() => {

diff --git a/static/app/views/performance/mobile/screenload/screenLoadSpans/table.tsx b/static/app/views/performance/mobile/screenload/screenLoadSpans/table.tsx
@@ -185,7 +185,7 @@ export function ScreenLoadSpansTable({
           onClick={() =>
             trackAnalytics('performance_views.sample_spans.opened', {
               organization,
-              source: ModuleName.SCREEN,
+              source: ModuleName.SCREEN_LOAD,
             })
           }
           to={`${pathname}?${qs.stringify(query)}`}

diff --git a/static/app/views/starfish/types.tsx b/static/app/views/starfish/types.tsx
@@ -16,8 +16,8 @@ export enum ModuleName {
   CACHE = 'cache',
   VITAL = 'vital',
   QUEUE = 'queue',
-  SCREEN = 'screen',
-  STARTUP = 'startup',
+  SCREEN_LOAD = 'screen_load',
+  APP_START = 'app_start',
   RESOURCE = 'resource',
   ALL = '',
   OTHER = 'other',

diff --git a/static/app/views/starfish/views/spans/selectors/actionSelector.tsx b/static/app/views/starfish/views/spans/selectors/actionSelector.tsx
@@ -105,8 +105,8 @@ const LABEL_FOR_MODULE_NAME: {[key in ModuleName]: ReactNode} = {
   cache: t('Action'),
   vital: t('Action'),
   queue: t('Action'),
-  screen: t('Action'),
-  startup: t('Action'),
+  screen_load: t('Action'),
+  app_start: t('Action'),
   resource: t('Resource'),
   other: t('Action'),
   '': t('Action'),

diff --git a/static/app/views/starfish/views/spans/selectors/domainSelector.tsx b/static/app/views/starfish/views/spans/selectors/domainSelector.tsx
@@ -173,8 +173,8 @@ const LABEL_FOR_MODULE_NAME: {[key in ModuleName]: ReactNode} = {
   cache: t('Domain'),
   vital: t('Domain'),
   queue: t('Domain'),
-  screen: t('Domain'),
-  startup: t('Domain'),
+  screen_load: t('Domain'),
+  app_start: t('Domain'),
   resource: t('Resource'),
   other: t('Domain'),
   '': t('Domain'),

diff --git a/static/app/views/starfish/views/spans/spanTimeCharts.tsx b/static/app/views/starfish/views/spans/spanTimeCharts.tsx
@@ -90,8 +90,8 @@ export function SpanTimeCharts({
     [ModuleName.CACHE]: [],
     [ModuleName.VITAL]: [],
     [ModuleName.QUEUE]: [],
-    [ModuleName.SCREEN]: [],
-    [ModuleName.STARTUP]: [],
+    [ModuleName.SCREEN_LOAD]: [],
+    [ModuleName.APP_START]: [],
     [ModuleName.RESOURCE]: features.includes(
       'starfish-browser-resource-module-bundle-analysis'
     )